[ADD] Estate Property Module by moahi-odoo · Pull Request #1190 · odoo/tutorials

moahi-odoo · 2026-03-10T12:51:48Z

initial setup of real estate module - Done
Basic structure of estate module - Done
Estate Property Model Using ORM -Done

initial setup of real estate module - Done Basic structure of estate module - Done Estate Property Model Using ORM -Done

robodoo · 2026-03-10T12:51:51Z

Solved Previous Issue Chapter 4 - done Security File Added

Views folder created with XML data file Action and Menu added in UI Learned how actions and menus work

Remaining Exercises - Done Added Active fields with Default Value Added State field with their Values

2 Exercise Solved Added List view to display records Added Form view to display one record in detail

mash-odoo

Hello!
Great start on the app..
I have added some comments..mostly nits.
Also please update the PR title

estate/models/estate_property.py

estate/security/ir.model.access.csv

estate/__manifest__.py

Applied all requested changes Added Search view Added Domain by filter and Group by filter

Completed Exercise 1 ,2 and 3 Added New models, fields, Action and Menus Completed Many2one and Many2many relations

mash-odoo

Hello!
Good going on the task...
Here are a few questions and suggestions.

mash-odoo · 2026-03-25T09:43:51Z

estate/models/estate_property.py

+    postcode = fields.Char()
+    date_availability = fields.Date(string="Available from", copy=False, default=lambda self: fields.Date.today() + timedelta(days=90))
+    expected_price = fields.Float(required=True)
+    selling_price = fields.Float(readonly=True, copy=True)


Do you know like where should we give readonly?

While declaring a field in .py file

While displaying it in UI side

we can give readonly for both .py and UI side

When the field should be readonly everywhere by default then we write it under .py and for UI if we want specific view to be readonly then we can add readonly to that specific view .

mash-odoo · 2026-03-25T09:47:33Z

estate/models/estate_property_offer.py

+    status = fields.Selection(
+        [
+            ('Accepted', "Accepted"),
+            ('Refused', "Refused")
+        ]
+        , copy=False)


Suggested change

status = fields.Selection(

[

('Accepted', "Accepted"),

('Refused', "Refused")

]

, copy=False)

status = fields.Selection(

[

('accepted', "Accepted"),

('refused', "Refused")

],

copy=False)

Try keeping the key in lowercase

mash-odoo · 2026-03-25T09:49:01Z

estate/views/estate_property_views.xml

+                <filter name="available" string="Available"
+                        domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>


Can you rewrite this domain in an optimized way?

mash-odoo · 2026-03-25T09:49:15Z

estate/views/estate_property_views.xml

+                <filter name="available" string="Available"
+                        domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>
+                <filter name="group_postcode" string="Postcode"
+                        context="{'group_by':'postcode'}"/>


Suggested change

context="{'group_by':'postcode'}"/>

context="{'group_by': 'postcode'}"/>

mash-odoo · 2026-03-25T09:50:14Z

estate/views/estate_property_views.xml

+            <sheet>
+
+                <h1>
+                    <field name="name" placeholder="Enter title..."/>
+                </h1>
+
+                <group>
+                    <group>
+                        <field name="tag_id" widget="many2many_tags"/>
+                        <field name="postcode"/>


Suggested change

<sheet>

<h1>

<field name="name" placeholder="Enter title..."/>

</h1>

<group>

<group>

<field name="tag_id" widget="many2many_tags"/>

<field name="postcode"/>

<sheet>

<h1>

<field name="name" placeholder="Enter title..."/>

</h1>

<group>

<group>

<field name="tag_id" widget="many2many_tags"/>

<field name="postcode"/>

Remove unnecessary empty lines from the entire file

mash-odoo · 2026-03-25T09:52:27Z

estate/models/estate_property.py

+from datetime import timedelta
+
+
+class EstateProperty(models.Model):


What are the different types of models which we can use?
Also why have you used models.Model here specifically?

There are 3 types models.Model , models.TransientModel and models.AbstractModel

i have used models.Model as we want to store its data permanently in the database

mash-odoo · 2026-03-25T09:53:40Z

estate/models/estate_property.py

+
+    property_type_id = fields.Many2one('estate.property.type', string="Property Type")
+    buyer_id = fields.Many2one('res.partner', string="Buyer", copy=False)
+    seller_id = fields.Many2one('res.users', string="Seller", default=lambda self: self.env.user)


What is a lambda function? And why do we need to use this function here?

lamda is small one line function and i have used it to set dynamic default value as when new record is been created then it set the date at that moment when the server starts

Completed last Exercise Added New model with their Form and list View Completed One2many relations

Completed 1st Exercise Added New total_area computed field Learned about computed field and applied suggestions

[ADD] Estate: Chapter 2 - 3 Finished

068874e

initial setup of real estate module - Done Basic structure of estate module - Done Estate Property Model Using ORM -Done

moahi-odoo force-pushed the 19.0-tutorials-estate-moahi branch from bea4c23 to c66d6ed Compare March 11, 2026 12:56

[IMP] Error Solved and Chapter 4 done

002667b

Solved Previous Issue Chapter 4 - done Security File Added

moahi-odoo force-pushed the 19.0-tutorials-estate-moahi branch from c66d6ed to 002667b Compare March 11, 2026 13:19

moahi-odoo added 2 commits March 12, 2026 18:40

[IMP] Chapter 5 Started

c510115

Views folder created with XML data file Action and Menu added in UI Learned how actions and menus work

[IMP] Chapter 5 Completed

8a9ce27

Remaining Exercises - Done Added Active fields with Default Value Added State field with their Values

moahi-odoo force-pushed the 19.0-tutorials-estate-moahi branch from 312f1cb to 8a9ce27 Compare March 16, 2026 04:40

[IMP] Chapter 6 Started

559cc00

2 Exercise Solved Added List view to display records Added Form view to display one record in detail

mash-odoo requested changes Mar 17, 2026

View reviewed changes

moahi-odoo changed the title ~~[ADD] Estate: Chapter 2 - 3 Finished~~ [ADD] Estate Property Module Mar 17, 2026

moahi-odoo added 2 commits March 17, 2026 18:55

[IMP] Chapter 6 done

477e0a3

Applied all requested changes Added Search view Added Domain by filter and Group by filter

[IMP] Chapter 7 Started

23ee740

Completed Exercise 1 ,2 and 3 Added New models, fields, Action and Menus Completed Many2one and Many2many relations

moahi-odoo force-pushed the 19.0-tutorials-estate-moahi branch 3 times, most recently from c78f742 to 44870df Compare March 22, 2026 08:11

mash-odoo requested changes Mar 25, 2026

View reviewed changes

[IMP] Chapter 7 Completed

806d439

Completed last Exercise Added New model with their Form and list View Completed One2many relations

moahi-odoo force-pushed the 19.0-tutorials-estate-moahi branch from 44870df to 806d439 Compare March 31, 2026 13:19

[IMP] Chapter 8 Started

46152b1

Completed 1st Exercise Added New total_area computed field Learned about computed field and applied suggestions

		<filter name="available" string="Available"
		domain="['\|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>

	context="{'group_by':'postcode'}"/>
	context="{'group_by': 'postcode'}"/>

		from datetime import timedelta


		class EstateProperty(models.Model):

Conversation

moahi-odoo commented Mar 10, 2026

Uh oh!

robodoo commented Mar 10, 2026

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants